-
Notifications
You must be signed in to change notification settings - Fork 20
Add explicit port handling in RESP connection callbacks #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andy1li
wants to merge
3
commits into
main
Choose a base branch
from
andy/fix-redis-cli-prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−87
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,36 @@ | ||
| package instrumented_resp_connection | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net" | ||
|
|
||
| resp_connection "github.com/codecrafters-io/redis-tester/internal/resp/connection" | ||
| resp_value "github.com/codecrafters-io/redis-tester/internal/resp/value" | ||
| "github.com/codecrafters-io/tester-utils/logger" | ||
| ) | ||
|
|
||
| const REDIS_DEFAULT_PORT = 6379 | ||
|
|
||
| type InstrumentedRespConnection struct { | ||
| *resp_connection.RespConnection | ||
|
|
||
| // Logger is used to log a connection's network activity (sent/received) | ||
| logger *logger.Logger | ||
| } | ||
|
|
||
| func defaultCallbacks(logger *logger.Logger) resp_connection.RespConnectionCallbacks { | ||
| func defaultCallbacks(logger *logger.Logger, remoteAddr net.Addr) resp_connection.RespConnectionCallbacks { | ||
| return resp_connection.RespConnectionCallbacks{ | ||
| BeforeSendCommand: func(reusedConnection bool, command string, args ...string) { | ||
| var commandPrefix string | ||
| if reusedConnection { | ||
| commandPrefix = ">" | ||
| } else { | ||
| commandPrefix = "$ redis-cli" | ||
| remotePort := remoteAddr.(*net.TCPAddr).Port | ||
| if remotePort == REDIS_DEFAULT_PORT { | ||
| commandPrefix = "$ redis-cli" | ||
| } else { | ||
| commandPrefix = fmt.Sprintf("$ redis-cli -p %d", remotePort) | ||
| } | ||
| } | ||
|
|
||
| commandWithArgs := append([]string{command}, args...) | ||
|
|
@@ -46,7 +54,13 @@ func defaultCallbacks(logger *logger.Logger) resp_connection.RespConnectionCallb | |
| func NewFromAddr(baseLogger *logger.Logger, addr string, connIdentifier string) (*InstrumentedRespConnection, error) { | ||
| logger := baseLogger.Clone() | ||
| logger.PushSecondaryPrefix(connIdentifier) | ||
| c, err := resp_connection.NewRespConnectionFromAddr(addr, defaultCallbacks(logger)) | ||
|
|
||
| remoteAddr, err := net.ResolveTCPAddr("tcp", addr) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure exactly what this does but Resolve sounds like it's doing a DNS lookup or something - is there a more safer version of this like "Parse" or so? |
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| c, err := resp_connection.NewRespConnectionFromAddr(addr, defaultCallbacks(logger, remoteAddr)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
@@ -59,7 +73,8 @@ func NewFromAddr(baseLogger *logger.Logger, addr string, connIdentifier string) | |
| func NewFromConn(baseLogger *logger.Logger, conn net.Conn, connIdentifier string) (*InstrumentedRespConnection, error) { | ||
| logger := baseLogger.Clone() | ||
| logger.PushSecondaryPrefix(connIdentifier) | ||
| c, err := resp_connection.NewRespConnectionFromConn(conn, defaultCallbacks(logger)) | ||
|
|
||
| c, err := resp_connection.NewRespConnectionFromConn(conn, defaultCallbacks(logger, conn.RemoteAddr())) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
@@ -83,7 +98,8 @@ func (c *InstrumentedRespConnection) UpdateBaseLogger(l *logger.Logger) { | |
| newLogger := l.Clone() | ||
| newLogger.PushSecondaryPrefix(c.GetIdentifier()) | ||
| c.logger = newLogger | ||
| c.UpdateCallBacks(defaultCallbacks(c.logger)) | ||
|
|
||
| c.UpdateCallBacks(defaultCallbacks(c.logger, c.Conn.RemoteAddr())) | ||
| } | ||
|
|
||
| func (c *InstrumentedRespConnection) SetReadValueInterceptor(transformer func(value resp_value.Value) resp_value.Value) { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to cast this to net.TCPAddr? Why can't we just accept net.TCPAddr directly in the function args?