Merged
Conversation
Change the return signature from (error, bool) to (bool, error) to follow Go's convention of placing the error as the last return value. Update the call site accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
assertEmptyAofFileCaseto use idiomatic Go error return order to prevent maintenance hazards.Note
Low Risk
Low risk: this is a small refactor that only changes the return-value ordering for
assertEmptyAofFileCaseand its caller, without altering assertion behavior.Overview
Adjusts
AofAppendOnlyFileAssertion.assertEmptyAofFileCaseto return(bool, error)(done-first, error-last) and updates theRun()call site accordingly, aligning with idiomatic Go and reducing the chance of misusing the results during future edits.Reviewed by Cursor Bugbot for commit b8b7fb6. Bugbot is set up for automated code reviews on this repo. Configure here.