Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk because changes are confined to the tester harness and fixtures, with only minor process lifecycle guarding in
RedisExecutable.Kill().Overview
AOF tests now validate
appendfsync. Default AOF config assertions includeCONFIG GET appendfsync(expectseverysec), and flag-based tests pass--appendfsyncand verify it viaCONFIG GET.Filesystem expectations around AOF directories are tightened. Adds
DirDoesNotExistAssertionand expands the AOF directory creation test to also assert the defaultappendonlydiris not created whenappendonlyis off, including updated fixtures.Improves executable lifecycle handling in tests.
RedisExecutablenow tracksisRunningto makeKill()idempotent, enabling mid-test terminate/restart patterns without spurious kill attempts.Reviewed by Cursor Bugbot for commit 22b2a52. Bugbot is set up for automated code reviews on this repo. Configure here.