Skip to content

⚡️ Speed up method Rank.__truediv__ by 15% #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Rank.__truediv__ by 15% #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion chromadb/execution/expression/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,13 @@ def __rmul__(self, other: Union[float, int]) -> "Mul":

def __truediv__(self, other: Union["Rank", float, int]) -> "Div":
"""Division: rank1 / rank2 or rank / value"""
other_rank = Val(other) if isinstance(other, (int, float)) else other
# Inline the isinstance check without tuple creation to avoid an extra allocation.
# Use direct type comparison for the common float and int cases for a micro-optimization.
t = type(other)
if t is float or t is int:
other_rank = Val(other)
else:
other_rank = other
return Div(self, other_rank)

def __rtruediv__(self, other: Union[float, int]) -> "Div":
Expand Down