Skip to content

⚡️ Speed up method TokenAuthClientProvider.authenticate by 381% #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method TokenAuthClientProvider.authenticate by 381% #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions chromadb/auth/token_authn/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,12 @@ def __init__(self, system: System) -> None:
super().__init__(system)
self._settings = system.settings

# Cache required settings and pre-compute token and transport header to minimize per-call work
system.settings.require("chroma_client_auth_credentials")
self._token = SecretStr(str(system.settings.chroma_client_auth_credentials))
_check_token(self._token.get_secret_value())
# token string is always immutable and safe to cache
token_value = str(system.settings.chroma_client_auth_credentials)
self._token = SecretStr(token_value)
_check_token(token_value)

if system.settings.chroma_auth_token_transport_header:
_check_allowed_token_headers(
Expand All @@ -101,15 +104,22 @@ def __init__(self, system: System) -> None:
else:
self._token_transport_header = TokenTransportHeader.AUTHORIZATION

@override
def authenticate(self) -> ClientAuthHeaders:
val = self._token.get_secret_value()
# Precompute full header value, respecting the chosen transport header
# This reduces string formatting and SecretStr allocation on every authenticate() call
if self._token_transport_header == TokenTransportHeader.AUTHORIZATION:
val = f"Bearer {val}"
return {
self._token_transport_header.value: SecretStr(val),
formatted_val = f"Bearer {token_value}"
else:
formatted_val = token_value
# Precompute the authentication header as a constant dictionary (SecretStr is immutable)
self._auth_header: ClientAuthHeaders = {
self._token_transport_header.value: SecretStr(formatted_val)
}

@override
def authenticate(self) -> ClientAuthHeaders:
# Just return the precomputed auth header for optimal speed and memory usage
return self._auth_header


class User(TypedDict):
"""
Expand Down