Skip to content

⚡️ Speed up method Limit.to_dict by 10% #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Limit.to_dict by 10% #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions chromadb/execution/expression/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,11 @@ class Limit:

def to_dict(self) -> Dict[str, Any]:
"""Convert the Limit to a dictionary for JSON serialization"""
result = {"offset": self.offset}
if self.limit is not None:
result["limit"] = self.limit
return result
# Fast path: avoid .get and dict manipulation
if self.limit is None:
return {"offset": self.offset}
# Avoid first initializing a partial dict then adding to it
return {"offset": self.offset, "limit": self.limit}

@staticmethod
def from_dict(data: Dict[str, Any]) -> "Limit":
Expand Down