-
Notifications
You must be signed in to change notification settings - Fork 22
fix failing tests due to fstrings mismatch & loosen pytest requirements #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit 75763b4)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
Persistent review updated to latest commit 75763b4 |
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Saga4 any idea why they're "expected"? |
| crosshair-tool = ">=0.0.78" | ||
| coverage = ">=7.6.4" | ||
| line_profiler=">=4.2.0" #this is the minimum version which supports python 3.13 | ||
| black = "^25.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we stopped requiring black since many users don't use black. Why do we require black, and not have it as an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this let's us not worry about fstring mismatch across all python versions, and instead let's black take care of it.
Pull request was closed
PR Type
Enhancement, Tests
Description
Introduce format_code_in_memory using black formatting
Replace sort_imports calls across modules
Update tests with new formatter assertions
Add black dependency and CI improvements
Changes walkthrough 📝
4 files
Add format_code_in_memory with black and isort integrationRefactor instrumentation to use new formatter functionReplace sort_imports with format_code_in_memory usageAdjust CI test command with warnings disabled3 files
Update formatter tests to use new function callUpdate instrumentation tests to compare formatted codeRevise instrumentation tests with formatter updates1 files
Add black dependency for consistent code formatting