Install black/ruff if not found in current python environment CF-495 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseembits93
changed the title
| formatter_cmds.append("black $file") | ||
| print("checking if black exists") | ||
| try: | ||
| import black |
There was a problem hiding this comment.
we should do this checking exactly the same way we run black when we do the formatting. I believe it runs as a subprocess. We should detect with that method if black is installed. The same goes for ruff formatter
| import black | ||
| except ImportError as e: | ||
| print("black not found, installing via pip") | ||
| subprocess.run(["pip", "install", "black"]) |
There was a problem hiding this comment.
we should not modify the user environment like this, only recommend the user to install black with this command. same for ruff
|
|
||
| Licensor: CodeFlash Inc. | ||
| Licensed Work: Codeflash Client version 0.9.x | ||
| Licensed Work: Codeflash Client version 0.0.x |
There was a problem hiding this comment.
also this file should be reverted
| # These version placeholders will be replaced by poetry-dynamic-versioning during `poetry build`. | ||
| __version__ = "0.9.2" | ||
| __version_tuple__ = (0, 9, 2) | ||
| __version__ = "0.0.0.post2491.dev0+2f81f2ca" |
There was a problem hiding this comment.
this file should also be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a try/except block which tries to import the formatter, it calls
pip installviasubprocessif the import fails.