Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Feb 18, 2025

Update test_results.py
Update parse_test_output.py
Update equivalence.py

@KRRT7 KRRT7 force-pushed the stdout_comparison_ branch from ace7938 to b265fa2 Compare February 18, 2025 11:25
@KRRT7 KRRT7 marked this pull request as ready for review February 18, 2025 11:32
@KRRT7 KRRT7 requested a review from misrasaurabh1 February 18, 2025 11:32
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs thorough unit testing

@KRRT7 KRRT7 requested a review from misrasaurabh1 February 21, 2025 02:32
@KRRT7 KRRT7 requested a review from misrasaurabh1 February 21, 2025 08:19
@codeflash-ai codeflash-ai deleted a comment from CLAassistant Feb 24, 2025
@KRRT7 KRRT7 requested a review from misrasaurabh1 February 28, 2025 19:25
@KRRT7 KRRT7 force-pushed the stdout_comparison_ branch from 1935a67 to 2fa1abc Compare February 28, 2025 21:45
codeflash stdout : BubbleSorter.sorter() called"""
assert test_results[1].stdout.strip() == out_str.strip()
out_str = """codeflash stdout : BubbleSorter.sorter() called\n\n\ncodeflash stdout : BubbleSorter.sorter() called"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this have \n whereas all others have proper newlines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was debugging something, forgot to revert.

KRRT7 added 2 commits March 3, 2025 16:59
Update pyproject.toml
Update test_instrument_tests.py
Update test_instrument_all_and_run.py
missing test
@KRRT7 KRRT7 force-pushed the stdout_comparison_ branch from 2fa1abc to dcf9384 Compare March 4, 2025 00:59
@KRRT7 KRRT7 merged commit 832b2eb into main Mar 4, 2025
15 checks passed
@KRRT7 KRRT7 deleted the stdout_comparison_ branch March 4, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants