⚡️ Speed up function _isbool by 28% in PR #217 (proper-cleanup)
#222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ This pull request contains optimizations for PR #217
If you approve this dependent PR, these changes will be merged into the original PR branch
proper-cleanup.📄 28% (0.28x) speedup for
_isboolincodeflash/code_utils/tabulate.py⏱️ Runtime :
41.2 microseconds→32.2 microseconds(best of98runs)📝 Explanation and details
Here’s an optimized version of your function.
Optimization notes:
type(x) is yis retained for speed.setinstantiation is avoided in favor of direct comparison for"True"and"False"when dealing with strings.strdirectly rather than combining withbytes, as"True"and"False"are not valid byte representations.bytesis strictly required (not functionally needed per the literal values in the set), let me know.✅ Correctness verification report:
🌀 Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-pr217-2025-05-19T04.33.11and push.