ensure type hints are reachable for nodes #243
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Crosshair needs the type hints to be reachable, we can avoid a subprocess call by just defensively checking if all the nodes have their type hints reachable
PR Type
Enhancement
Description
Added type_hints_reachable helper function
Guarded concolic test generation with check
Added tests for type_hints_reachable behavior
Changes walkthrough 📝
static_analysis.py
Add type_hints_reachable functioncodeflash/code_utils/static_analysis.py
concolic_testing.py
Guard concolic tests with reachable hintscodeflash/verification/concolic_testing.py
test_static_analysis.py
Test type_hints_reachable behaviortests/test_static_analysis.py