Skip to content

Don't display result in report table if INIT_STATE_TEST #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Don't display result in report table if INIT_STATE_TEST #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6da525
Don't display result if INIT_STATE_TEST
davidgirdwood1 Feb 24, 2025
488d4fa
Use the to_name()
davidgirdwood1 Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions codeflash/github/PrComment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ class PrComment:
winning_benchmarking_test_results: TestResults

def to_json(self) -> dict[str, Union[dict[str, dict[str, int]], int, str]]:

report_table = {
test_type.to_name(): result
for test_type, result in self.winning_behavioral_test_results.get_test_pass_fail_report_by_type().items()
if test_type.should_display_result()
}

Copy link
Contributor

@KRRT7 KRRT7 Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need the extra method here, we can just inline it in the comprehension directly. i.e

        report_table = {
            test_type.to_name(): result
            for test_type, result in self.winning_behavioral_test_results.get_test_pass_fail_report_by_type().items()
            if test_type.to_name()
        }

return {
"optimization_explanation": self.optimization_explanation,
"best_runtime": humanize_runtime(self.best_runtime),
Expand All @@ -29,10 +36,7 @@ def to_json(self) -> dict[str, Union[dict[str, dict[str, int]], int, str]]:
"speedup_x": self.speedup_x,
"speedup_pct": self.speedup_pct,
"loop_count": self.winning_benchmarking_test_results.number_of_loops(),
"report_table": {
test_type.to_name(): result
for test_type, result in self.winning_behavioral_test_results.get_test_pass_fail_report_by_type().items()
},
"report_table": report_table
}


Expand Down
3 changes: 3 additions & 0 deletions codeflash/verification/test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ class TestType(Enum):
CONCOLIC_COVERAGE_TEST = 5
INIT_STATE_TEST = 6

def should_display(self) -> bool:
return self != TestType.INIT_STATE_TEST

def to_name(self) -> str:
if self == TestType.INIT_STATE_TEST:
return ""
Expand Down
Loading