Skip to content

Rich error output during baseline establishment (CF-646) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 2, 2025
Merged

Rich error output during baseline establishment (CF-646) #265

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c002c24
maybe something other than logger info
aseembits93 Jun 2, 2025
5d82d86
rich text output for user to look at
aseembits93 Jun 2, 2025
1c6a11c
precommit fix
aseembits93 Jun 2, 2025
c2d494f
test
aseembits93 Jun 2, 2025
3f6547d
compile regex pattern
aseembits93 Jun 2, 2025
045f914
display during test discovery too
aseembits93 Jun 2, 2025
4ce5f96
only display the part from Modulenotfound onwards
aseembits93 Jun 2, 2025
9d8e0a2
modify test
aseembits93 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion codeflash/discovery/discover_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,16 @@

import pytest
from pydantic.dataclasses import dataclass
from rich.panel import Panel
from rich.text import Text

from codeflash.cli_cmds.console import console, logger, test_files_progress_bar
from codeflash.code_utils.code_utils import custom_addopts, get_run_tmp_file, module_name_from_file_path
from codeflash.code_utils.code_utils import (
ImportErrorPattern,
custom_addopts,
get_run_tmp_file,
module_name_from_file_path,
)
from codeflash.code_utils.compat import SAFE_SYS_EXECUTABLE, codeflash_cache_db
from codeflash.models.models import CodePosition, FunctionCalledInTest, TestsInFile, TestType

Expand Down Expand Up @@ -180,6 +187,10 @@ def discover_tests_pytest(
logger.warning(
f"Failed to collect tests. Pytest Exit code: {exitcode}={pytest.ExitCode(exitcode).name}\n {error_section}"
)
if "ModuleNotFoundError" in result.stdout:
match = ImportErrorPattern.search(result.stdout).group()
panel = Panel(Text.from_markup(f"⚠️ {match} ", style="bold red"), expand=False)
console.print(panel)

elif 0 <= exitcode <= 5:
logger.warning(f"Failed to collect tests. Pytest Exit code: {exitcode}={pytest.ExitCode(exitcode).name}")
Expand Down
Loading