Skip to content

[Chore] warn message if the module root and test root are the same (CF-659) #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 6, 2025
Merged

[Chore] warn message if the module root and test root are the same (CF-659) #266

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fcc30b7
warn message if the user provide same module root and test root
mohammedahmed18 Jun 2, 2025
951a12d
log the warn message during configuration
mohammedahmed18 Jun 3, 2025
d3107c8
typos
mohammedahmed18 Jun 3, 2025
6d276f7
oops
mohammedahmed18 Jun 3, 2025
7beee94
fix formatting
mohammedahmed18 Jun 3, 2025
493b103
merge main
mohammedahmed18 Jun 4, 2025
e086e4c
Merge branch 'main' into chore/modules-and-tests-same-path
misrasaurabh1 Jun 6, 2025
a54d652
Merge branch 'main' of github.com:codeflash-ai/codeflash into chore/m…
mohammedahmed18 Jun 6, 2025
34c5a8f
Merge branch 'chore/modules-and-tests-same-path' of github.com:mohamm…
mohammedahmed18 Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codeflash/cli_cmds/cmd_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ def init_codeflash() -> None:

if should_modify_pyproject_toml():
setup_info: SetupInfo = collect_setup_info()

if Path(setup_info.module_root).resolve() == Path(setup_info.tests_root).resolve():
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it when the user is actually entering the test directory, not after he is done.
Also remove the module_root path from the list of options when asking for the test_root. This will mostly solve the problem. We can still keep the warning in case the user enters the module_root path manually

logger.warning(
"It looks like your tests root is the same as your module root. This is not recommended and can lead to unexpected behavior."
)
configure_pyproject_toml(setup_info)

install_github_app()
Expand Down
Loading