Skip to content

⚡️ Speed up method CharacterRemover.remove_control_characters by 46% #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up method CharacterRemover.remove_control_characters by 46% #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions code_to_optimize/remove_control_chars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import re


class CharacterRemover:
def __init__(self):
self.version = "0.1"
# Build translation table once in init.
self._ctrl_table = self._make_ctrl_table()

def remove_control_characters(self, s) -> str:
"""Remove control characters from the string."""
return re.sub("[\\x00-\\x1F\\x7F]", "", s) if s else ""
return s.translate(self._ctrl_table) if s else ""

def _make_ctrl_table(self):
# Map delete (ASCII 127) and 0-31 to None
ctrl_chars = dict.fromkeys(range(32), None)
ctrl_chars[127] = None
return str.maketrans(ctrl_chars)
Loading