Skip to content

Save replay tests to test dir #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

Save replay tests to test dir #317

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cedf3f1
saving replay tests to test dir
aseembits93 Jun 11, 2025
b6a68ed
Merge branch 'main' into replay-test-save-dir
aseembits93 Jun 11, 2025
a497b81
modify docs
aseembits93 Jun 12, 2025
8d66fd4
update manual config doc
aseembits93 Jun 12, 2025
d8b2ad6
update docs
aseembits93 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions codeflash/cli_cmds/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@ def process_pyproject_config(args: Namespace) -> Namespace:
assert Path(args.benchmarks_root).is_dir(), (
f"--benchmarks-root {args.benchmarks_root} must be a valid directory"
)
assert Path(args.benchmarks_root).resolve().is_relative_to(Path(args.tests_root).resolve()), (
f"--benchmarks-root {args.benchmarks_root} must be a subdirectory of --tests-root {args.tests_root}"
)
if env_utils.get_pr_number() is not None:
import git

Expand Down
2 changes: 1 addition & 1 deletion codeflash/optimization/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def run(self) -> None:
trace_file.unlink()

self.replay_tests_dir = Path(
tempfile.mkdtemp(prefix="codeflash_replay_tests_", dir=self.args.benchmarks_root)
tempfile.mkdtemp(prefix="codeflash_replay_tests_", dir=self.args.tests_root)
)
trace_benchmarks_pytest(
self.args.benchmarks_root, self.args.tests_root, self.args.project_root, trace_file
Expand Down
Loading