Skip to content

⚡️ Speed up function function_kind by 6% #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up function function_kind by 6% #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions codeflash/code_utils/static_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

from pydantic import BaseModel, ConfigDict, field_validator

from codeflash.models.models import FunctionParent

if TYPE_CHECKING:
from codeflash.models.models import FunctionParent

Expand Down Expand Up @@ -139,14 +141,20 @@ def get_first_top_level_function_or_method_ast(


def function_kind(node: ast.FunctionDef | ast.AsyncFunctionDef, parents: list[FunctionParent]) -> FunctionKind | None:
if not parents or parents[0].type in ["FunctionDef", "AsyncFunctionDef"]:
# Fast exit if no parents or parent is function
if not parents:
return FunctionKind.FUNCTION
parent_type = parents[0].type
if parent_type in _FUNCTION_OR_ASYNC:
return FunctionKind.FUNCTION
if parents[0].type == "ClassDef":
if parent_type == "ClassDef":
# Use a set for quick id matching, short-circuit as soon as possible
for decorator in node.decorator_list:
if isinstance(decorator, ast.Name):
if decorator.id == "classmethod":
did = decorator.id
if did == "classmethod":
return FunctionKind.CLASS_METHOD
if decorator.id == "staticmethod":
if did == "staticmethod":
return FunctionKind.STATIC_METHOD
return FunctionKind.INSTANCE_METHOD
return None
Expand All @@ -159,3 +167,6 @@ def has_typed_parameters(node: ast.FunctionDef | ast.AsyncFunctionDef, parents:
if kind in [FunctionKind.CLASS_METHOD, FunctionKind.INSTANCE_METHOD]:
return all(arg.annotation for arg in node.args.args[1:])
return False


_FUNCTION_OR_ASYNC = {"FunctionDef", "AsyncFunctionDef"}
Loading