Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Jun 26, 2025

PR Type

Enhancement


Description

  • Remove hardcoded Python interpreter path

  • Extend pytest to ignore benchmarks directory

  • Rename and refine debug configuration

  • Add prompt for custom working directory


Changes walkthrough 📝

Relevant files
Configuration changes
codeflash.code-workspace
Update workspace settings and debug configs                           

codeflash.code-workspace

  • Removed default Python interpreter path and launch.version
  • Expanded pytestArgs to ignore benchmarks folder
  • Renamed debug configuration and updated cwd input
  • Added inputs.chooseCwd prompt for directory
  • +17/-7   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    JSON Syntax

    Verify that the updated workspace file remains valid JSON; ensure proper comma placement and balanced braces around the new inputs section.

            "inputs": [
                {
                    "id": "chooseCwd",
                    "type": "promptString",
                    "description": "Enter the working directory for codeflash",
                }
            ]
        },
    }
    Pytest ignore flag

    Confirm that separating --ignore and the directory path is correctly interpreted by pytest; consider using --ignore=tests/benchmarks/ if needed.

    "python.testing.pytestArgs": [
        "tests/",
        "-vv",
        "--ignore",
        "tests/benchmarks/"
    ],
    Custom CWD prompt

    Ensure that prompting for chooseCwd provides a sensible default or validation to prevent launch failures if the input is empty or invalid.

            "cwd": "${input:chooseCwd}",
            "console": "integratedTerminal",
            "env": {
                "PYTHONUNBUFFERED": "1"
            }
        }
    ],
    "inputs": [
        {
            "id": "chooseCwd",
            "type": "promptString",
            "description": "Enter the working directory for codeflash",
        }

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Re-add launch version field

    VSCode launch configurations require a "version" field at the top level. Re-add
    "version": "0.2.0", before "configurations" so the workspace can be parsed
    correctly.

    codeflash.code-workspace [22-23]

     "launch": {
    +    "version": "0.2.0",
         "configurations": [
    Suggestion importance[1-10]: 8

    __

    Why: Adding "version": "0.2.0" restores the required VSCode launch schema and prevents parse errors.

    Medium
    Remove trailing comma in args

    JSON does not allow trailing commas in arrays. Remove the comma after "--all" to
    ensure the launch config is valid JSON.

    codeflash.code-workspace [72-74]

     "args": [
    -    "--all",
    +    "--all"
     ],
    Suggestion importance[1-10]: 6

    __

    Why: Standard JSON disallows trailing commas; removing the comma after "--all" ensures the file remains valid.

    Low
    Remove trailing comma in input

    JSON syntax forbids trailing commas in objects. Delete the comma after the last
    property in the input object to avoid parsing errors.

    codeflash.code-workspace [86]

    -"description": "Enter the working directory for codeflash",
    +"description": "Enter the working directory for codeflash"
    Suggestion importance[1-10]: 6

    __

    Why: The trailing comma after the last property in the input object breaks JSON syntax and must be removed.

    Low

    @KRRT7 KRRT7 enabled auto-merge June 26, 2025 22:07
    @KRRT7 KRRT7 requested a review from a team June 26, 2025 22:14
    @KRRT7 KRRT7 merged commit 9dbc536 into main Jun 27, 2025
    16 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants