Skip to content

[FIX] Circular dependency and global assignments imports #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2025
Merged

[FIX] Circular dependency and global assignments imports #448

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bdb11d0
don't import from same module
mohammedahmed18 Jun 27, 2025
b4e9ab7
formatting
mohammedahmed18 Jun 27, 2025
0212e01
remove unused imports in one go
mohammedahmed18 Jun 28, 2025
2acda6a
initial test files
mohammedahmed18 Jun 28, 2025
2e394f6
tests and fix global assignments imports
mohammedahmed18 Jun 28, 2025
190d593
fix: tests expected code new lines
mohammedahmed18 Jun 28, 2025
0b18bca
Merge branch 'main' into fix/cicular-imports-in-helper-context
misrasaurabh1 Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codeflash/code_utils/code_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,10 @@ def add_needed_imports_from_module(
RemoveImportsVisitor.remove_unused_import(dst_context, mod)
for mod, obj_seq in gatherer.object_mapping.items():
for obj in obj_seq:
if f"{mod}.{obj}" in helper_functions_fqn:
if (
f"{mod}.{obj}" in helper_functions_fqn
or dst_context.full_module_name is mod # avoid circular imports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer == over is

):
continue # Skip adding imports for helper functions already in the context
AddImportsVisitor.add_needed_import(dst_context, mod, obj)
RemoveImportsVisitor.remove_unused_import(dst_context, mod, obj)
Expand Down
Loading