-
Notifications
You must be signed in to change notification settings - Fork 22
[Feat] add staging argument #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think of adding staging-review related E2E tests as a task to linear to track.
LGTM only small question around generated_tests.
PR Type
Enhancement
Description
Add
--staging-reviewCLI optionIntroduce
create_stagingAPI endpointRefactor PR creation into
process_reviewRoute to staging or GitHub PR based on args
Changes diagram
Changes walkthrough 📝
cfapi.py
Add create_staging API functioncodeflash/api/cfapi.py
get_current_branch,git_root_dir,FileDiffContent,PrCommentcreate_stagingfunction for staging PRsdiffContentsandprCommentFieldsJSONfunction_optimizer.py
Refactor PR logic and add staging pathcodeflash/optimization/function_optimizer.py
create_stagingin CF API importsprocess_reviewmethodprocess_reviewroutes tocreate_stagingorcheck_create_prcli.py
Add staging-review CLI flagcodeflash/cli_cmds/cli.py
--staging-reviewCLI argument