Skip to content

Catch yet another exception #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
+40 −38
Merged

Catch yet another exception #506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dd0962
try except
misrasaurabh1 Jul 2, 2025
97de78b
try except
misrasaurabh1 Jul 2, 2025
29c0200
Merge branch 'main' into catch-yet-another-exception
KRRT7 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 40 additions & 38 deletions codeflash/discovery/discover_unit_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,45 +624,47 @@ def process_test_files(
except Exception as e:
logger.debug(str(e))
continue

if not definition or definition[0].type != "function":
continue

definition_obj = definition[0]
definition_path = str(definition_obj.module_path)

project_root_str = str(project_root_path)
if (
definition_path.startswith(project_root_str + os.sep)
and definition_obj.module_name != name.module_name
and definition_obj.full_name is not None
):
# Pre-compute common values outside the inner loop
module_prefix = definition_obj.module_name + "."
full_name_without_module_prefix = definition_obj.full_name.replace(module_prefix, "", 1)
qualified_name_with_modules_from_root = f"{module_name_from_file_path(definition_obj.module_path, project_root_path)}.{full_name_without_module_prefix}"

for test_func in test_functions_by_name[scope]:
if test_func.parameters is not None:
if test_framework == "pytest":
scope_test_function = f"{test_func.function_name}[{test_func.parameters}]"
else: # unittest
scope_test_function = f"{test_func.function_name}_{test_func.parameters}"
else:
scope_test_function = test_func.function_name

function_to_test_map[qualified_name_with_modules_from_root].add(
FunctionCalledInTest(
tests_in_file=TestsInFile(
test_file=test_file,
test_class=test_func.test_class,
test_function=scope_test_function,
test_type=test_func.test_type,
),
position=CodePosition(line_no=name.line, col_no=name.column),
try:
if not definition or definition[0].type != "function":
continue
definition_obj = definition[0]
definition_path = str(definition_obj.module_path)

project_root_str = str(project_root_path)
if (
definition_path.startswith(project_root_str + os.sep)
and definition_obj.module_name != name.module_name
and definition_obj.full_name is not None
):
# Pre-compute common values outside the inner loop
module_prefix = definition_obj.module_name + "."
full_name_without_module_prefix = definition_obj.full_name.replace(module_prefix, "", 1)
qualified_name_with_modules_from_root = f"{module_name_from_file_path(definition_obj.module_path, project_root_path)}.{full_name_without_module_prefix}"

for test_func in test_functions_by_name[scope]:
if test_func.parameters is not None:
if test_framework == "pytest":
scope_test_function = f"{test_func.function_name}[{test_func.parameters}]"
else: # unittest
scope_test_function = f"{test_func.function_name}_{test_func.parameters}"
else:
scope_test_function = test_func.function_name

function_to_test_map[qualified_name_with_modules_from_root].add(
FunctionCalledInTest(
tests_in_file=TestsInFile(
test_file=test_file,
test_class=test_func.test_class,
test_function=scope_test_function,
test_type=test_func.test_type,
),
position=CodePosition(line_no=name.line, col_no=name.column),
)
)
)
num_discovered_tests += 1
num_discovered_tests += 1
except Exception as e:
logger.debug(str(e))
continue

progress.advance(task_id)

Expand Down
Loading