Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Jul 3, 2025

PR Type

Enhancement


Description

  • Removed module discovery info panel

  • Simplified prompt asking module root

  • Dropped benchmarks-root in pyproject config


Changes walkthrough 📝

Relevant files
Enhancement
cmd_init.py
Clean up init prompts and config                                                 

codeflash/cli_cmds/cmd_init.py

  • Deleted info_panel displaying module discovery prompts
  • Removed extra console print newline
  • Eliminated codeflash_section['benchmarks-root'] assignment
  • +0/-14   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @KRRT7 KRRT7 requested a review from misrasaurabh1 July 3, 2025 22:18
    @github-actions
    Copy link

    github-actions bot commented Jul 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing prompt choices

    The new inquirer.List prompt for module_root defines the message but does not include a choices parameter (e.g., module_subdir_options), which may cause the prompt to show no options or error.

    questions = [
        inquirer.List(
            "module_root",
            message="Which Python module do you want me to optimize?",
    Benchmarks removal impact

    The PR drops the benchmarks-root entry from the pyproject config. Verify that any code or tests relying on setup_info.benchmarks_root handle its absence correctly to avoid attribute errors or unexpected defaults.

    codeflash_section["module-root"] = setup_info.module_root
    codeflash_section["tests-root"] = setup_info.tests_root
    codeflash_section["test-framework"] = setup_info.test_framework
    codeflash_section["ignore-paths"] = setup_info.ignore_paths
    codeflash_section["disable-telemetry"] = not enable_telemetry

    @github-actions
    Copy link

    github-actions bot commented Jul 3, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @KRRT7 KRRT7 requested a review from misrasaurabh1 July 3, 2025 22:33
    @misrasaurabh1 misrasaurabh1 merged commit ed6ffe4 into main Jul 3, 2025
    16 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants