Skip to content

⚡️ Speed up function quantity_of_tests_critic by 76% in PR #517 (early-skip-if-insufficient-number-of-tests-passed) #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: early skip if quantity of tests not sufficient for original baseline
wants to merge 1 commit into from
Closed

⚡️ Speed up function quantity_of_tests_critic by 76% in PR #517 (early-skip-if-insufficient-number-of-tests-passed) #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions codeflash/result/critic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
MIN_IMPROVEMENT_THRESHOLD,
MIN_TESTCASE_PASSED_THRESHOLD,
)
from codeflash.models.models import TestType
from codeflash.models.models import OptimizedCandidateResult, OriginalCodeBaseline, TestType

if TYPE_CHECKING:
from codeflash.models.models import CoverageData, OptimizedCandidateResult, OriginalCodeBaseline
Expand Down Expand Up @@ -52,16 +52,27 @@ def speedup_critic(

def quantity_of_tests_critic(candidate_result: OptimizedCandidateResult | OriginalCodeBaseline) -> bool:
test_results = candidate_result.behavior_test_results
report = test_results.get_test_pass_fail_report_by_type()

# Fast path: compute report, pass_count and REPLAY_TEST in a single loop
report = {}
pass_count = 0
for test_type in report:
pass_count += report[test_type]["passed"]
replay_pass = 0
for test_result in test_results.test_results:
if test_result.loop_index == 1:
ttype = test_result.test_type
if ttype not in report:
report[ttype] = {"passed": 0, "failed": 0}
if test_result.did_pass:
report[ttype]["passed"] += 1
pass_count += 1
if ttype == TestType.REPLAY_TEST:
replay_pass += 1
else:
report[ttype]["failed"] += 1

if pass_count >= MIN_TESTCASE_PASSED_THRESHOLD:
return True
# If one or more tests passed, check if least one of them was a successful REPLAY_TEST
return bool(pass_count >= 1 and report[TestType.REPLAY_TEST]["passed"] >= 1)
# If at least one test passed, check if at least one was a successful REPLAY_TEST
return bool(pass_count >= 1 and replay_pass >= 1)


def coverage_critic(original_code_coverage: CoverageData | None, test_framework: str) -> bool:
Expand Down
Loading