Warning Message for users using old versions #631
Closed
+334
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Saga4
reviewed
Aug 7, 2025
codeflash/version.py
Outdated
| @@ -1,2 +1,6 @@ | |||
| # These version placeholders will be replaced by uv-dynamic-versioning during build. | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
we can remove this file from local version testing.
There was a problem hiding this comment.
@mihikap01 we can remove this file from the scope of this PR.
Saga4
reviewed
Aug 10, 2025
| return | ||
|
|
||
| # Get current version dynamically to handle runtime changes | ||
| from codeflash.version import __version__ as current_version |
There was a problem hiding this comment.
we already have this as global import.
Saga4
reviewed
Aug 11, 2025
| args = parse_args() | ||
|
|
||
| # Check for newer version (skip for version command to avoid confusion) | ||
| if not args.version: |
There was a problem hiding this comment.
With version check 'codeflash --version' we can also show the status if its outdated.
Saga4
reviewed
Aug 11, 2025
| # Check for newer version (skip for version command to avoid confusion) | ||
| if not args.version: | ||
| # Check if version check is disabled in config | ||
| disable_version_check = False |
There was a problem hiding this comment.
I am not sure we are going to add this in the configs or existing configs with customers.
We can just have a direct non blocking check.
Saga4
reviewed
Aug 11, 2025
| return _version_cache["version"] | ||
|
|
||
| try: | ||
| response = requests.get("https://pypi.org/pypi/codeflash/json", timeout=10) |
There was a problem hiding this comment.
nit: can have quick timeout here to make it non blocking if there is network issue.
|
Tested here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prints warning messages when the user tries to run an old version of codeflash.
closes https://linear.app/codeflash-ai/issue/CF-700/print-a-warning-if-the-current-codeflash-version-is-not-the-latest