Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Aug 14, 2025

User description

a vanilla extend replaces the built in ruff https://docs.astral.sh/ruff/settings/#exclude exclusion rules, we want to extend instead.


PR Type

Bug fix


Description

  • Replace exclude with extend-exclude in Ruff config

File Walkthrough

Relevant files
Configuration changes
pyproject.toml
Use `extend-exclude` in Ruff config                                           

pyproject.toml

  • Updated Ruff configuration
  • Changed exclude to extend-exclude directive
+1/-1     

@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Config Placement

Ensure extend-exclude is defined under the correct [tool.ruff] section so that Ruff recognizes and applies the extended exclusion rules.

extend-exclude = ["code_to_optimize/", "pie_test_set/", "tests/"]

@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@misrasaurabh1 misrasaurabh1 self-requested a review August 14, 2025 19:24
@aseembits93
Copy link
Contributor

@KRRT7 what is the consequence of this change?

@KRRT7 KRRT7 enabled auto-merge August 14, 2025 19:28
@KRRT7
Copy link
Contributor Author

KRRT7 commented Aug 14, 2025

@KRRT7 what is the consequence of this change?

generally shouldn't notice it. with the current configuration ruff was linting / formatting files in my .git folder (which ruff ignores by default but we were replacing it with our own list, you can see what ruff ignores by default at https://docs.astral.sh/ruff/settings/#exclude)

@KRRT7 KRRT7 merged commit ea12bb3 into main Aug 14, 2025
18 of 20 checks passed
@KRRT7 KRRT7 deleted the fix-ruff-extend branch August 14, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants