-
Couldn't load subscription status.
- Fork 22
[Chore] Log staging link #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
screenshot just in case you saved it @HeshamHM28 , Looks good to me |
PR Type
Enhancement
Description
Handle create_staging response status codes
Print staging URL on success
Print failure message with status code
Generate URL using trace and experiment ID
Diagram Walkthrough
File Walkthrough
function_optimizer.py
Add staging link loggingcodeflash/optimization/function_optimizer.py
create_stagingresponse inresponseresponse.status_codefor success