Skip to content

[FIX] log final explanation #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2025
Merged

[FIX] log final explanation #668

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3fed4e
fix: show final explanation only
mohammedahmed18 Aug 18, 2025
19cd223
explanation_v2 filed
mohammedahmed18 Aug 19, 2025
370e4e6
explanation_v2
mohammedahmed18 Aug 19, 2025
60df8f6
Merge branch 'main' of github.com:codeflash-ai/codeflash into fix/exp…
mohammedahmed18 Aug 19, 2025
90eaf90
send the new explanation from the lsp server
mohammedahmed18 Aug 19, 2025
aefe030
keep it frozen & remove unused lsp methods
mohammedahmed18 Aug 19, 2025
c4e15cf
Merge branch 'main' into fix/explanation-print
mohammedahmed18 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codeflash/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class TestsInFile:
test_type: TestType


@dataclass(frozen=True)
@dataclass
class OptimizedCandidate:
source_code: CodeStringsMarkdown
explanation: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why we arent having old explanation and new explanation as sep field here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would propose to keep it frozen. we can instantiate a new candidate with the new explanation. we don't want to corrupt the existing data we have.

Expand Down
5 changes: 3 additions & 2 deletions codeflash/optimization/function_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ def find_and_process_best_optimization(
original_helper_code,
code_context,
)
self.log_successful_optimization(explanation, generated_tests, exp_type)
self.log_successful_optimization(best_optimization.candidate.explanation, generated_tests, exp_type)
return best_optimization

def process_review(
Expand Down Expand Up @@ -1232,7 +1232,8 @@ def process_review(
file_path=explanation.file_path,
benchmark_details=explanation.benchmark_details,
)
console.print(Panel(new_explanation_raw_str, title="Best Candidate Explanation", border_style="blue"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print should remain there @mohammedahmed18

Copy link
Contributor Author

@mohammedahmed18 mohammedahmed18 Aug 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aseembits93
already printed here

1234|        self.log_successful_optimization(new_explanation, generated_tests, exp_type)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good @mohammedahmed18

best_optimization.candidate.explanation = new_explanation

data = {
"original_code": original_code_combined,
"new_code": new_code_combined,
Expand Down
Loading