-
Couldn't load subscription status.
- Fork 22
Revamp and polish the docs more #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Saurabh Misra <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Saurabh Misra <[email protected]>
| 1. **Python 3.9 or above** installed | ||
| 2. **A Python project** with a virtual environment | ||
| 3. **Project dependencies installed** in your virtual environment | ||
| 4. **Tests** (optional) for your code (Codeflash uses tests to verify optimizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Existing Tests are good to have.
We can include this in "good to have" category?
| 4. Which test framework do you use? (pytest/unittest) | ||
| 1. Enter your Codeflash API key: | ||
| 2. Install the GitHub app. | ||
| 3. Which Python module do you want me to optimize going forward? (e.g. my_module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: e.g. src/
|
|
||
| # Check your pyproject.toml configuration | ||
| cat pyproject.toml | grep -A 5 "\[tool.codeflash\]" | ||
| cat pyproject.toml | grep -A 8 "\[tool.codeflash\]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Can add verification withcodeflash --verify post setup.
| 4. **Run Codeflash :** | ||
|
|
||
| Benchmark mode is best used together with Codeflash as a Github Action. This way, with every PR, you will know the impact of Codeflash's optimizations on your benchmarks. | ||
| Benchmark mode is best used together with Codeflash as a GitHub Action. This way, if new code in a Pull Request touches the benchmark workflow, Codeflash will try to optimize the code for the benchmark, and you will know the impact of Codeflash's optimizations on your benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Codeflash will try to optimize the code for the benchmark
Maybe we can write something like "Codeflash will trace through your benchmarks step to optimize the functions modified in your PR which touches the benchmark workflow, and you will ..
|
|
||
| Since it runs on all the functions in your codebase, it can take some time to complete, please be patient. | ||
| As this runs you will see Codeflash opening pull requests for each function it successfully optimizes. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ # Optimize your sub-directory codebase
Signed-off-by: Saurabh Misra <[email protected]>
PR Type
Documentation
Description
Revise site navigation groups and labels
Refine installation and usage instructions
Enhance PR and GitHub Actions docs
Update benchmarks and tracer guidelines
File Walkthrough
11 files
Update benchmarking link path formatRevise navigation groups and labelsRefine local installation instructionsUpdate best practices workflow headingsRefresh overview content and featuresEnhance benchmark setup and usage stepsExpand codebase optimization guidanceImprove GitHub Actions integration guideAdjust single function optimization sidebarRemove outdated PR optimization pageRefine trace and optimize workflow docs