Skip to content

⚡️ Speed up function install_github_app by 235,820% in PR #670 (vsc/environment-validation) #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up function install_github_app by 235,820% in PR #670 (vsc/environment-validation) #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions codeflash/api/cfapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,7 @@ def is_github_app_installed_on_repo(owner: str, repo: str, *, suppress_errors: b
:param suppress_errors: If True, suppress error logging when the app is not installed.
:return: True if the app is installed, False otherwise.
"""
response = make_cfapi_request(
endpoint=f"/is-github-app-installed?repo={repo}&owner={owner}", method="GET", suppress_errors=suppress_errors
)
return response.ok and response.text == "true"
return _cached_is_github_app_installed_on_repo(owner, repo, suppress_errors)


def get_blocklisted_functions() -> dict[str, set[str]] | dict[str, Any]:
Expand Down Expand Up @@ -344,3 +341,11 @@ def send_completion_email() -> Response:
return response
payload = {"owner": owner, "repo": repo}
return make_cfapi_request(endpoint="/send-completion-email", method="POST", payload=payload)


@lru_cache(maxsize=128)
def _cached_is_github_app_installed_on_repo(owner: str, repo: str, suppress_errors: bool) -> bool:
response = make_cfapi_request(
endpoint=f"/is-github-app-installed?repo={repo}&owner={owner}", method="GET", suppress_errors=suppress_errors
)
return response.ok and response.text == "true"
Loading