Skip to content

⚡️ Speed up method AsyncCallInstrumenter._call_in_positions by 69% in PR #739 (get-throughput-from-output) #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up method AsyncCallInstrumenter._call_in_positions by 69% in PR #739 (get-throughput-from-output) #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions codeflash/code_utils/instrument_existing_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,27 @@

def node_in_call_position(node: ast.AST, call_positions: list[CodePosition]) -> bool:
if isinstance(node, ast.Call) and hasattr(node, "lineno") and hasattr(node, "col_offset"):
node_lineno = node.lineno
node_end_lineno = node.end_lineno
node_col_offset = node.col_offset
node_end_col_offset = node.end_col_offset

for pos in call_positions:
pos_line_no = pos.line_no
if (
pos.line_no is not None
and node.end_lineno is not None
and node.lineno <= pos.line_no <= node.end_lineno
pos_line_no is not None
and node_end_lineno is not None
and node_lineno <= pos_line_no <= node_end_lineno
):
if pos.line_no == node.lineno and node.col_offset <= pos.col_no:
if pos_line_no == node_lineno and node_col_offset <= pos.col_no:
return True
if (
pos.line_no == node.end_lineno
and node.end_col_offset is not None
and node.end_col_offset >= pos.col_no
pos_line_no == node_end_lineno
and node_end_col_offset is not None
and node_end_col_offset >= pos.col_no
):
return True
if node.lineno < pos.line_no < node.end_lineno:
if node_lineno < pos_line_no < node_end_lineno:
return True
return False

Expand Down
Loading