Skip to content

import variable correctly #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

import variable correctly #747

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51ceda7
Update test_runner.py
KRRT7 Sep 23, 2025
5a425c3
Update test_runner.py
KRRT7 Sep 23, 2025
4c8b76f
Update test_runner.py
KRRT7 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions codeflash/verification/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codeflash.cli_cmds.console import logger
from codeflash.code_utils.code_utils import custom_addopts, get_run_tmp_file
from codeflash.code_utils.compat import IS_POSIX, SAFE_SYS_EXECUTABLE
from codeflash.code_utils.config_consts import get_total_looping_time
from codeflash.code_utils.config_consts import TOTAL_LOOPING_TIME_EFFECTIVE
from codeflash.code_utils.coverage_utils import prepare_coverage_files
from codeflash.models.models import TestFiles, TestType

Expand Down Expand Up @@ -37,7 +37,6 @@ def run_behavioral_tests(
pytest_timeout: int | None = None,
pytest_cmd: str = "pytest",
verbose: bool = False,
pytest_target_runtime_seconds: int = get_total_looping_time(),
enable_coverage: bool = False,
) -> tuple[Path, subprocess.CompletedProcess, Path | None, Path | None]:
if test_framework == "pytest":
Expand Down Expand Up @@ -66,7 +65,6 @@ def run_behavioral_tests(
"--codeflash_loops_scope=session",
"--codeflash_min_loops=1",
"--codeflash_max_loops=1",
f"--codeflash_seconds={pytest_target_runtime_seconds}", # TODO : This is unnecessary, update the plugin to not ask for this
]

result_file_path = get_run_tmp_file(Path("pytest_results.xml"))
Expand Down Expand Up @@ -151,7 +149,6 @@ def run_line_profile_tests(
cwd: Path,
test_framework: str,
*,
pytest_target_runtime_seconds: float = get_total_looping_time(),
verbose: bool = False,
pytest_timeout: int | None = None,
pytest_min_loops: int = 5, # noqa: ARG001
Expand Down Expand Up @@ -186,7 +183,6 @@ def run_line_profile_tests(
"--codeflash_loops_scope=session",
"--codeflash_min_loops=1",
"--codeflash_max_loops=1",
f"--codeflash_seconds={pytest_target_runtime_seconds}",
]
result_file_path = get_run_tmp_file(Path("pytest_results.xml"))
result_args = [f"--junitxml={result_file_path.as_posix()}", "-o", "junit_logging=all"]
Expand Down Expand Up @@ -237,7 +233,7 @@ def run_benchmarking_tests(
cwd: Path,
test_framework: str,
*,
pytest_target_runtime_seconds: float = get_total_looping_time(),
pytest_target_runtime_seconds: float = TOTAL_LOOPING_TIME_EFFECTIVE,
verbose: bool = False,
pytest_timeout: int | None = None,
pytest_min_loops: int = 5,
Expand Down
Loading