-
Notifications
You must be signed in to change notification settings - Fork 22
[Worktree] mirror the path for the args.all #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify one of the E2E tests inplace to use --worktree and use that as a E2E test for worktrees as well
|
@KRRT7 will create a separate pr for this later |
PR Type
Bug fix
Description
Mirror
args.allpath in worktree modeAlign
args.allwithmodule_rootmirroringDiagram Walkthrough
File Walkthrough
optimizer.py
Add worktree mirroring for args.allcodeflash/optimization/optimizer.py
self.args.allwhen setmirror_pathwithoriginal_git_rootandworktree_dirargs.allmirrorsmodule_rootpath