-
Notifications
You must be signed in to change notification settings - Fork 22
add 3.14 to the matrix #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit 774ee63)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 774ee63
Previous suggestionsSuggestions up to commit bf633fe
|
|
it was originally failing because a transitive dependency did not support 3.14, they've since added support |
|
Persistent review updated to latest commit 774ee63 |
| run: uv sync | ||
|
|
||
| - name: Install test-only dependencies (Python 3.13) | ||
| if: matrix.python-version == '3.13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not applicable for 3.9, 3.10, 3.11 and 3.12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests dependencies can be very heavy and take a long time to download, i don't want to 5-10x tests runtime unnecesarily, 3.13 is a good enough compromise
PR Type
Enhancement
Description
Diagram Walkthrough
File Walkthrough
unit-tests.yaml
Add Python 3.14 to test matrix.github/workflows/unit-tests.yaml
python-versionmatrix to include3.14