Skip to content

⚡️ Speed up method Graph.topologicalSort by 62% #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: don't import future as standalone
wants to merge 1 commit into from
Closed

⚡️ Speed up method Graph.topologicalSort by 62% #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions code_to_optimize/topological_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,19 @@ def topologicalSortUtil(self, v, visited, stack):
visited[v] = True

for i in self.graph[v]:
if visited[i] == False:
if not visited[i]:
self.topologicalSortUtil(i, visited, stack)

stack.insert(0, v)
stack.append(v) # Changed from insert(0, v) to append for efficiency

def topologicalSort(self):
visited = [False] * self.V
stack = []
sorting_id = uuid.uuid4()

for i in range(self.V):
if visited[i] == False:
if not visited[i]:
self.topologicalSortUtil(i, visited, stack)

stack.reverse() # Reverse once for output order instead of inefficient insert(0, v)
return stack, str(sorting_id)
Loading