Skip to content

filter optimization reviews before PR #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

filter optimization reviews before PR #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codeflash/api/aiservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def optimize_python_code_refinement(self, request: list[AIServiceRefinerRequest]
logger.debug(f"Refining {len(request)} optimizations…")
console.rule()
try:
response = self.make_ai_service_request("/refinement", payload=payload, timeout=60)
response = self.make_ai_service_request("/refinement", payload=payload, timeout=120)
except requests.exceptions.RequestException as e:
logger.exception(f"Error generating optimization refinements: {e}")
ph("cli-optimize-error-caught", {"error": str(e)})
Expand Down Expand Up @@ -597,7 +597,7 @@ def get_optimization_review(
}
console.rule()
try:
response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=60)
response = self.make_ai_service_request("/optimization_review", payload=payload, timeout=120)
except requests.exceptions.RequestException as e:
logger.exception(f"Error generating optimization refinements: {e}")
ph("cli-optimize-error-caught", {"error": str(e)})
Expand Down
6 changes: 3 additions & 3 deletions codeflash/api/cfapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def suggest_changes(
"coverage_message": coverage_message,
"replayTests": replay_tests,
"concolicTests": concolic_tests,
"optimizationImpact": optimization_review, # impact keyword left for legacy reasons, touches js/ts code
"optimizationReview": optimization_review, # impact keyword left for legacy reasons, touches js/ts code
}
return make_cfapi_request(endpoint="/suggest-pr-changes", method="POST", payload=payload)

Expand Down Expand Up @@ -200,7 +200,7 @@ def create_pr(
"coverage_message": coverage_message,
"replayTests": replay_tests,
"concolicTests": concolic_tests,
"optimizationImpact": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
"optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
}
return make_cfapi_request(endpoint="/create-pr", method="POST", payload=payload)

Expand Down Expand Up @@ -257,7 +257,7 @@ def create_staging(
"coverage_message": coverage_message,
"replayTests": replay_tests,
"concolicTests": concolic_tests,
"optimizationImpact": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
"optimizationReview": optimization_review, # Impact keyword left for legacy reasons, it touches js/ts codebase
}

return make_cfapi_request(endpoint="/create-staging", method="POST", payload=payload)
Expand Down
5 changes: 2 additions & 3 deletions codeflash/optimization/function_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ def process_review(

raise_pr = not self.args.no_pr
staging_review = self.args.staging_review

opt_review_response = ""
if raise_pr or staging_review:
data["root_dir"] = git_root_dir()
calling_fn_details = get_opt_review_metrics(
Expand All @@ -1468,15 +1468,14 @@ def process_review(
self.project_root,
self.test_cfg.tests_root,
)
opt_review_response = ""
try:
opt_review_response = self.aiservice_client.get_optimization_review(
**data, calling_fn_details=calling_fn_details
)
except Exception as e:
logger.debug(f"optimization review response failed, investigate {e}")
data["optimization_review"] = opt_review_response
if raise_pr and not staging_review:
if raise_pr and not staging_review and opt_review_response != "low":
data["git_remote"] = self.args.git_remote
check_create_pr(**data)
elif staging_review:
Expand Down
Loading