Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/signal/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,16 @@ def manual_convolution_1d(signal: np.ndarray, kernel: np.ndarray) -> np.ndarray:
kernel_len = len(kernel)
result_len = signal_len - kernel_len + 1
result = np.zeros(result_len)
for i in range(result_len):
for j in range(kernel_len):
result[i] += signal[i + j] * kernel[j]
# Use vectorized operations for performance
# Create a 2D view of the portions of signal for each convolution step
if result_len <= 0:
return result # Preserve behavior for empty result
strided = np.lib.stride_tricks.as_strided(
signal,
shape=(result_len, kernel_len),
strides=(signal.strides[0], signal.strides[0]),
)
result[:] = np.dot(strided, kernel)
return result


Expand Down