Skip to content

⚡️ Speed up function find_leaf_nodes by 18,209% #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up function find_leaf_nodes by 18,209% #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/dsa/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,10 @@ def find_last_node(nodes, edges):

# Function to find all leaf nodes (nodes with no outgoing edges)
def find_leaf_nodes(nodes: list[dict], edges: list[dict]) -> list[dict]:
leaf_nodes = []
for node in nodes:
is_leaf = True
for edge in edges:
if edge["source"] == node["id"]:
is_leaf = False
break
if is_leaf:
leaf_nodes.append(node)
return leaf_nodes
# Build a set of all node ids that are sources in the edge list
source_ids = {edge["source"] for edge in edges}
# Return all nodes whose id is not in the source_ids set
return [node for node in nodes if node["id"] not in source_ids]


JsonRef = NewType("JsonRef", str)
Expand Down