Skip to content

⚡️ Speed up function _get_safe_command by 98% #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _get_safe_command by 98% #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sentry_sdk/integrations/redis/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
def _get_safe_command(name, args):
# type: (str, Sequence[Any]) -> str
command_parts = [name]
name_low = name.lower()
send_pii = None

for i, arg in enumerate(args):
if i > _MAX_NUM_ARGS:
break

name_low = name.lower()

if name_low in _COMMANDS_INCLUDING_SENSITIVE_DATA:
command_parts.append(SENSITIVE_DATA_SUBSTITUTE)
continue
Expand All @@ -35,7 +35,9 @@ def _get_safe_command(name, args):
command_parts.append(repr(arg))

else:
if should_send_default_pii():
if send_pii is None:
send_pii = should_send_default_pii()
if send_pii:
command_parts.append(repr(arg))
else:
command_parts.append(SENSITIVE_DATA_SUBSTITUTE)
Expand Down