Skip to content

⚡️ Speed up function _get_input_attributes by 40% #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _get_input_attributes by 40% #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions sentry_sdk/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,9 @@ def _fill_sample_rand(self):
)
return

self.dynamic_sampling_context["sample_rand"] = f"{sample_rand:.6f}" # noqa: E231
self.dynamic_sampling_context["sample_rand"] = (
f"{sample_rand:.6f}" # noqa: E231
)

def _sample_rand(self):
# type: () -> Optional[str]
Expand Down Expand Up @@ -1030,27 +1032,21 @@ def _get_input_attributes(template, send_pii, args, kwargs):
"top_k": (SPANDATA.GEN_AI_REQUEST_TOP_K, int),
}

def _set_from_key(key, value):
# type: (str, Any) -> None
if key in mapping:
(attribute, data_type) = mapping[key]
if value is not None and isinstance(value, data_type):
attributes[attribute] = value

for key, value in list(kwargs.items()):
for key, value in kwargs.items():
if key == "prompt" and isinstance(value, str):
attributes.setdefault(SPANDATA.GEN_AI_REQUEST_MESSAGES, []).append(
{"role": "user", "content": value}
)
messages = attributes.setdefault(SPANDATA.GEN_AI_REQUEST_MESSAGES, [])
messages.append({"role": "user", "content": value})
continue

if key == "system_prompt" and isinstance(value, str):
attributes.setdefault(SPANDATA.GEN_AI_REQUEST_MESSAGES, []).append(
{"role": "system", "content": value}
)
messages = attributes.setdefault(SPANDATA.GEN_AI_REQUEST_MESSAGES, [])
messages.append({"role": "system", "content": value})
continue

_set_from_key(key, value)
if key in mapping:
attribute, data_type = mapping[key]
if value is not None and isinstance(value, data_type):
attributes[attribute] = value

if template == SPANTEMPLATE.AI_TOOL and send_pii:
attributes[SPANDATA.GEN_AI_TOOL_INPUT] = safe_repr(
Expand Down