-
Notifications
You must be signed in to change notification settings - Fork 0
Add packaging process for state clients #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| type: string | ||
|
|
||
| push: | ||
| tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can build packages automatically by tagging a commit with a version or state-version. In the latter case the version will only be applied to the specific state. We can also manually trigger a packaging via the UI.
| @@ -0,0 +1,264 @@ | |||
| /** | |||
| * Search Query Helpers for Safety Net API Clients | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I returned this utility because I thought it would be handy. It is now included in the packages.
|
This should wait until #5 is merged. There is a problem with the application overlay being applied that I'd like to fix. It will be easier to address after the application is not a moving target. |
906ebf1 to
6f96c7b
Compare
| console.log(`\n Processing ${domain}...`); | ||
|
|
||
| // Bundle spec (dereference $refs) | ||
| await exec('npx', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this call?
|
Hey @lkacenja @mryhmln, big fan of @codeforamerica! In one of your negatives, "Separate type and Zod files vs. combined", I'm wondering if something like this would help you? If the concern is around the amount of files, you can collapse them into a single file if you wish. Let me know if I'm misunderstanding that bullet point. |
Our Open API Spec can be transformed into Zod clients. Currently there is no easy way to use those clients. We have also been working on creating state-specific Open API overlays that add configuration to the base API spec. We should apply the state overlays and make the Zod clients available as a package.
This PR adds a packaging workflow to create precompiled Zod clients that may be imported into projects via NPM.