Skip to content

Bug/diverging analysis id uifix to main #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thadk merged 3 commits into from
Feb 4, 2026
Merged

Bug/diverging analysis id uifix to main #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8383cb5
Bug/654/census codespace block w corsanywhere (#658)
thadk Jan 28, 2026
d557c27
Prettier fix for #658 (#659)
thadk Jan 28, 2026
1a3c730
Fix bug where UI could not link to cases where analysis and caseid we…
thadk Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/heat-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ jobs:
name: 🎭 Playwright
runs-on: ubuntu-22.04
timeout-minutes: 60
# CORS proxy settings for geocoding API calls
env:
VITE_CORS_PROXY_URL: ${{ secrets.VITE_CORS_PROXY_URL }}
VITE_CORS_ORIGIN: ${{ secrets.VITE_CORS_ORIGIN }}
steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v4
Expand Down
8 changes: 4 additions & 4 deletions heat-stack/app/routes/cases+/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default function Cases({
<td className="whitespace-nowrap px-6 py-4">
<div className="text-sm font-medium text-gray-900">
<Link
to={`/cases/${firstAnalysis?.id}/edit?edit_mode=true`}
to={`/cases/${caseItem.id}/edit?edit_mode=true`}
className="text-sm font-medium text-indigo-700 underline hover:underline"
>
{caseItem.id}
Expand Down Expand Up @@ -170,19 +170,19 @@ export default function Cases({
</td>
<td className="whitespace-nowrap px-6 py-4">
<Link
to={`/cases/${firstAnalysis?.id}`}
Copy link
Member Author

@thadk thadk Feb 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the original ID was weirdly correct for View button. The Original LLM PR implemented view route using Analysis ID and everyone else for the other routes implemented using case ID.

to={`/cases/${caseItem.id}`}
className="mx-1 text-indigo-600 hover:text-indigo-900"
>
View
</Link>
<Link
to={`/cases/${firstAnalysis?.id}/edit`}
to={`/cases/${caseItem.id}/edit`}
className="mx-1 text-indigo-600 hover:text-indigo-900"
>
Edit
</Link>
<Link
to={`/cases/${firstAnalysis?.id}/delete`}
to={`/cases/${caseItem.id}/delete`}
className="hover:text-indigo-9001 mx-1 text-indigo-600"
>
Delete
Expand Down
16 changes: 13 additions & 3 deletions heat-stack/app/utils/GeocodeUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
const BASE_URL = 'https://geocoding.geo.census.gov'
const BASE_URL =
import.meta.env.VITE_CORS_PROXY_URL ?? 'https://geocoding.geo.census.gov'
const CORS_ORIGIN = import.meta.env.VITE_CORS_ORIGIN
const ADDRESS_ENDPOINT = '/geocoder/geographies/onelineaddress'

// Build headers only if origin is defined
const headers = CORS_ORIGIN
? {
Origin: CORS_ORIGIN,
'X-Requested-With': 'XMLHttpRequest',
}
: undefined

// example: https://geocoding.geo.census.gov/geocoder/geographies/onelineaddress?address=1%20broadway%2C%20cambridge%2C%20ma%2002142&benchmark=4&vintage=4&format=json
interface CensusGeocoderResponse {
result: {
Expand Down Expand Up @@ -93,8 +103,8 @@ class GeocodeUtil {

/** TODO: note that for this Census API you can specify particular parts of this that
we want (x, y, state_id, and county_id for now), read the docs */
let url = new URL(BASE_URL + ADDRESS_ENDPOINT + '?' + params.toString())
let rezzy = await fetch(url)
const url = new URL(BASE_URL + ADDRESS_ENDPOINT + '?' + params.toString())
let rezzy = await fetch(url, headers ? { headers } : undefined)
let jrez = (await rezzy.json()) as CensusGeocoderResponse
// TODO: Return all addresses and let the user choose the right one
// const fs = await import('node:fs')
Expand Down