Skip to content

Conversation

jicruz96
Copy link
Collaborator

@jicruz96 jicruz96 commented Aug 6, 2025

Summary

Handles extraction of translate-able string from all search-related components.

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • [n/a] I've made pages responsive and look good on mobile.

Screenshots

Click to see all the screenshots Screenshot 2025-08-07 at 1 08 46 AM Screenshot 2025-08-07 at 1 03 45 AM Screenshot 2025-08-07 at 12 56 27 AM Screenshot 2025-08-07 at 12 54 36 AM Screenshot 2025-08-07 at 12 54 13 AM Screenshot 2025-08-07 at 12 20 44 AM Screenshot 2025-08-07 at 1 10 49 AM Screenshot 2025-08-07 at 1 10 59 AM

Steps to test/reproduce

Check that the following components look unchanged relative to prod (screenshots available in screenshot section if you lazy and you trust me):

  • Titles of bill search & testimony search refinement filters.
  • Sorting values of bill search and testimony pages.
  • Bill name and testimony author name in a testimony search result.
  • Result count (i.e. "Showing x-y of z Results" display under search bar)
  • Search some gibberish in both bill and testimony search to confirm that empty search results messages look the same.
  • Copy this.state.error = "test error" onto line 17 of components/search/SearchErrorBoundary.tsx to enduce a search error. Confirm the error message looks correct.

Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
maple-dev Ready Ready Preview Comment Aug 19, 2025 11:36pm

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I don't want to merge this until we get a chance to discuss at hack night (for unrelated reasons - I noticed a regression in the Search Filters behavior on PROD while checking this out and don't want to commit to this refactoring until we know what broke).

@jicruz96
Copy link
Collaborator Author

jicruz96 commented Aug 11, 2025

Code looks good, but I don't want to merge this until we get a chance to discuss at hack night (for unrelated reasons - I noticed a regression in the Search Filters behavior on PROD while checking this out and don't want to commit to this refactoring until we know what broke).

No sweat. Seems a merge conflict popped up after a different PR was merged. Hopefully it works this time around.

edit: I bombed fixing the merge conflict. sorry. Should be fixed now.

@jicruz96 jicruz96 force-pushed the search-component-translations branch from e5b0686 to 43cc11e Compare August 11, 2025 18:30
@Mephistic
Copy link
Collaborator

Code still looks good to me! - looks like you just need to resolve the merge conflict introduced since we merged #1892 to main and then we can merge this.

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mephistic Mephistic merged commit aa04d45 into codeforboston:main Aug 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants