-
-
Notifications
You must be signed in to change notification settings - Fork 141
Search component translations #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search component translations #1883
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I don't want to merge this until we get a chance to discuss at hack night (for unrelated reasons - I noticed a regression in the Search Filters behavior on PROD while checking this out and don't want to commit to this refactoring until we know what broke).
No sweat. Seems a merge conflict popped up after a different PR was merged. Hopefully it works this time around. edit: I bombed fixing the merge conflict. sorry. Should be fixed now. |
e5b0686
to
43cc11e
Compare
Code still looks good to me! - looks like you just need to resolve the merge conflict introduced since we merged #1892 to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Handles extraction of translate-able string from all search-related components.
Checklist
Screenshots
Click to see all the screenshots
Steps to test/reproduce
Check that the following components look unchanged relative to prod (screenshots available in screenshot section if you lazy and you trust me):
this.state.error = "test error"
onto line 17 ofcomponents/search/SearchErrorBoundary.tsx
to enduce a search error. Confirm the error message looks correct.