Skip to content

extract translate-able text -- Partners page #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

jicruz96
Copy link
Collaborator

@jicruz96 jicruz96 commented Aug 7, 2025

Summary

  • Extracts translate-able strings from the Partners page (in the About -> Our Team section).
  • Refactor this section's code for DRYness + lower surface area.

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • [n/a] I've made pages responsive and look good on mobile.

Screenshots

Left side is mapletestimony.org | Right side is this branch

Screenshot 2025-08-07 at 1 45 03 AM

Known issues

Not pixel-perfect

Keen eyes will notice very slight variations between the existing page and my refactor. Did you notice?

  • NuLawLab's description has slightly different spacing.
  • PID's description text breaks at different words.

These changes are very miniscule. They're worth it if it makes the code DRYer (Ok honestly I just wanted to have fun with a refactor tonight and I'm just trying to justify it 😅).

I can walk balk the intensity of the refactor in order to preserve the exact position of every pixel if requested.

Steps to test/reproduce

  1. Go to page /about/our-team and click on the partners tab.
  2. Confirm it looks the same as prod.

Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 6:00am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mertbagt mertbagt merged commit c922c4d into codeforboston:main Aug 12, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants