Skip to content

Result view - include label/name in tooltip #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 28, 2025
Merged

Result view - include label/name in tooltip #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25660c1
feat: add column label/name to tooltip in result view
janfh Apr 21, 2025
d9a4d90
fix: tooltip formatting in result view
janfh Apr 22, 2025
b0c2fb7
Enable extended metadata as default
janfh Apr 22, 2025
622975b
Update tooltip when switching between label/name in header
janfh Apr 22, 2025
1b6bf65
Merge branch 'main' into feature/column_label_preview
janfh Apr 22, 2025
bb24910
Merge remote-tracking branch 'origin/main'
janfh Apr 28, 2025
9ff5c5d
Merge branch 'main' into feature/column_label_preview
janfh Apr 28, 2025
fafa86a
fix extended metadata
janfh Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/connection/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ export class SQLJobManager {
"transaction isolation": "none",
"query optimize goal": "1",
"block size": "512",
"date format": "iso"
"date format": "iso",
"extended metadata": true,
}));

try {
Expand Down
60 changes: 35 additions & 25 deletions src/views/results/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,31 +434,7 @@ export function generateScroller(basicSelect: string, isCL: boolean, withCancel?
columnMetaData.map(column => {
var cell = headerRow.insertCell();
cell.appendChild(document.createTextNode(columnHeadings === 'Label' ? column.label : column.name));
switch (column.type) {
case 'CHAR':
case 'VARCHAR':
case 'CLOB':
case 'BINARY':
case 'VARBINARY':
case 'BLOB':
case 'GRAPHIC':
case 'VARGRAPHIC':
case 'DBCLOB':
case 'NCHAR':
case 'NVARCHAR':
case 'NCLOB':
case 'FLOAT':
case 'DECFLOAT':
case 'DATALINK':
cell.title = column.type + '(' + column.precision + ')';
break;
case 'DECIMAL':
case 'NUMERIC':
cell.title = column.type + '(' + column.precision + ', ' + column.scale + ')';
break;
default:
cell.title = column.type;
}
cell.title = getTooltip(column, columnHeadings);
});

// Initialize the footer
Expand Down Expand Up @@ -537,9 +513,43 @@ export function generateScroller(basicSelect: string, isCL: boolean, withCancel?
var headerCells = document.getElementById(htmlTableId).getElementsByTagName('thead')[0].rows[0].cells;
for (let x = 0; x < headerCells.length; ++x) {
headerCells[x].innerText = columnHeadings === 'Label' ? columnMetaData[x].label : columnMetaData[x].name;
headerCells[x].title = getTooltip(columnMetaData[x], columnHeadings);
}
}
}

function getTooltip(column, columnHeadings) {
let title = '';
switch (column.type) {
case 'CHAR':
case 'VARCHAR':
case 'CLOB':
case 'BINARY':
case 'VARBINARY':
case 'BLOB':
case 'GRAPHIC':
case 'VARGRAPHIC':
case 'DBCLOB':
case 'NCHAR':
case 'NVARCHAR':
case 'NCLOB':
case 'FLOAT':
case 'DECFLOAT':
case 'DATALINK':
title = column.type + '(' + column.precision + ')';
break;
case 'DECIMAL':
case 'NUMERIC':
title = column.type + '(' + column.precision + ', ' + column.scale + ')';
break;
default:
title = column.type;
}
title += \`\\n\`;
title += columnHeadings === 'Label' ? column.name : column.label;
return title;
}

</script>
</head>
<body style="padding: 0;">
Expand Down
Loading