Skip to content

Conversation

janfh
Copy link
Contributor

@janfh janfh commented Jun 3, 2025

Option to exclude generated columns from sql-qualifier insert statements

Fixes #392
Fixes #355

  • Bumped mapepire-server to 2.3.3
  • Bumped mapepire-js to 0.6.0
  • New option sqlIncludeGeneratedColumns
  • Remove autogenerated columns from sql insert statements if enabled

@worksofliam worksofliam linked an issue Jun 3, 2025 that may be closed by this pull request
@worksofliam worksofliam self-requested a review June 3, 2025 15:57
@worksofliam
Copy link
Member

@janfh This is marked as draft. Is it ready or shall I wait?

@janfh
Copy link
Contributor Author

janfh commented Jun 4, 2025

@janfh This is marked as draft. Is it ready or shall I wait?

I need to test some more. Not sure if we get enough info to exclude "generated always" (not auto increment). I actually think all columns should be included when using "select *". The data might be inserted into another table with another definition. What do you think?

@worksofliam
Copy link
Member

I actually think all columns should be included when using "select *". The data might be inserted into another table with another definition.

I agree with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump mapepire-server version to 2.3.3 sql: prefix to take generated columns into account
2 participants