Skip to content

Enhance runCommand with error handling and event callbacks#2481

Merged
worksofliam merged 2 commits intomasterfrom
fix/variables_in_ui
Jan 26, 2025
Merged

Enhance runCommand with error handling and event callbacks#2481
worksofliam merged 2 commits intomasterfrom
fix/variables_in_ui

Conversation

@worksofliam
Copy link
Member

Patrick B raised an issue with me directly about this issue.

When I use the default commands I get the variable names in the prompt, but the command runs with the proper values.

I have a couple of custom actions that aren't working properly...the variable names appear in the form, and are also used in the command:

This new change fixes the issue where the variables were appearing in both confirmation UIs before they were expanded.

Include unit tests for variable expansion in ILE commands.

…vent callbacks

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Jan 25, 2025
@github-actions
Copy link
Contributor

👋 A new build is available for this PR based on e31ab07.

@p-behr
Copy link
Contributor

p-behr commented Jan 26, 2025

Confirming that variable replacement in actions works :-)

@worksofliam worksofliam temporarily deployed to testing_environment January 26, 2025 21:25 — with GitHub Actions Inactive
@worksofliam worksofliam merged commit 974e4c2 into master Jan 26, 2025
1 check passed
@sebjulliand sebjulliand deleted the fix/variables_in_ui branch October 23, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants