Default to using a diff when tracking source dates #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Contributor
|
👋 A new build is available for this PR based on 1b6a205. |
worksofliam
changed the title
worksofliam
had a problem deploying
to
testing_environment
GitHub Actions
Failure
SanjulaGanepola
requested changes
Feb 26, 2025
Member
SanjulaGanepola
left a comment
SanjulaGanepola
left a comment
There was a problem hiding this comment.
Just a couple comments + we should update the description for code-for-ibmi.showDateSearchButton:
If enabled, will show the 'Date search' button in the status bar when source dates with diff mode is enabled.
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
SanjulaGanepola
approved these changes
Feb 26, 2025
Member
SanjulaGanepola
left a comment
SanjulaGanepola
left a comment
There was a problem hiding this comment.
Changes look good and it works as expected now!
Going back to my previous comment, shouldn't we drop the "when source dates with diff mode is enabled." for showDateSearchButton?
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Member
Author
|
@SanjulaGanepola I am following now. I removed the |
Member
|
I was thinking just drop that part of the description, but your completely right in that we don't need that option all together. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes the ability to configure which mode will be used to track source date changes, and we now default to
diff, which tracks changes based on the previous save of the file.No functional changes here, only UX changes. Documentation may need to be updated after merge.
How to test this PR
Examples:
Checklist
console.logs I added