Skip to content

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will fix the error reported in issue #2524 by returning the date 1970-01-01 00:00:00 when the source member date is not initialized, i.e. the date does not start with a '1' or '0'. This is the case when a member is created and not yet used: The QUSRMBRD API will return hexadecimal zeroes for the member change date if the member has never been refreshed.

A test for valid dates from GetMbrInfo has also been added.

How to test this PR

Examples:

  1. Run the test cases

Checklist

  • have tested my change
  • have created one or more test cases

@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Feb 21, 2025
@chrjorgensen chrjorgensen linked an issue Feb 21, 2025 that may be closed by this pull request
@chrjorgensen chrjorgensen temporarily deployed to testing_environment February 21, 2025 18:15 — with GitHub Actions Inactive
@worksofliam worksofliam merged commit e522bf4 into codefori:master Feb 21, 2025
1 of 2 checks passed
@worksofliam
Copy link
Member

I mistakenly merged this PR. The tests didn't run here, and I mistook that as a pass. I ran them locally after I merged and they are failing (including the test case).

I have created a fix in #2525, and Christian has a change in #2523 which will also fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes GetMemberInfo throws an SQL error
2 participants