Skip to content

Conversation

chrjorgensen
Copy link
Collaborator

@chrjorgensen chrjorgensen commented Jul 18, 2025

Changes

This PR will disable all commands used for changing content on the server, if the connection is marked readonly.
This include terminals and run of actions, but not library list change command or action management etc.

EDIT: C4i will now ask for reload when the readonly value changes in the config.

EDIT: The readonly field has been moved to the Features section as the first option:

image

EDIT: The readonly connection setting is decribed in the PR #71 in the Docs repo.

EDIT: Save As will now fail with filesystem error if the connection is in readonly mode.

How to test this PR

  1. Open a connection marked as readonly
  2. No commands for changing server content should not be available and greyed out in the context menus
  3. Change the connection config, unmark readonly and reconnect.
  4. The commands for changing server content should now be available as usual.

Checklist

  • have tested my change
  • updated relevant documentation

@chrjorgensen chrjorgensen marked this pull request as draft July 18, 2025 20:14
@chrjorgensen chrjorgensen marked this pull request as ready for review July 18, 2025 23:14
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one issue I found:

The deploy command still works even in readonly mode (should be a simple package.json addition)

Once that's done, I think we can merge.

Great work!

@worksofliam
Copy link
Member

@chrjorgensen I saw you mentioned you're on holiday - let me take over this PR for you.

@worksofliam
Copy link
Member

@sebjulliand I've added one small commit to this PR. Any chance you can have a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants