Bidi CCSID Support via Extension Settings #2826
Open
+152
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added two new extension settings(index.ts): 1. Enable Bidi conversion 2. Target CCSID for Bidi conversion - Modified IBMiContent to apply Bidi-aware conversion logic when enabled via user settings, including fallback and error handling.
Extends the Bidi handling to also apply when uploading source members back to the IBM i.
…urce Dates are enabled
|
@yuvalnn This is look like a good start, but we're going to need some granular tests in |
- Added BiDi test cases in src/api/tests/suites/encoding.test.ts - Covers Hebrew (CCSID 424) and Arabic (CCSID 420) - Includes helper convertToUTF8WithCCSID and edge cases
|
@worksofliam I’ve added a new synchronous test suite in encoding.test.ts to cover the BiDi changes, thanks to the work from @Itsanexpriment The suite includes: We kept this in a separate suite to avoid interfering with existing async tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds configurable Bidi (bi-directional text) support for source members encoded in CCSIDs like 424, 420, and others.
Features
New extension settings under "Source Code":
Enable Bidi support for member editing(checkbox).Bidi-compatible CCSID(number input).Conversion logic only runs when enabled in the settings.
Encoding is handled via IFS-based copy to avoid corruption.
The implementation is cleanly isolated to avoid side effects.
How to test this PR
Enable Bidi support for member editing.Bidi-compatible CCSID.Checklist
console.logs I added